VM/Transaction trait/struct refactoring #155

sorpaas · 2017-06-01T11:07:52Z

Part of #152.

Solution: add with_states fn for Machine

Solution: add TransactionVM

Solution: add with_states for VM

Solution: implement VM trait for TransactionVM

Solution: add code for Transaction::gas_limit

Solution: move necessary cost to transaction and impl intrinsic_gas

Solution: implement into_context for message call and contract creation

Solution: pub use

Solution: utilize Transaction::into_context for those two opcodes

Solution: utilize Transaction::into_context for CREATE

Solution: use SeqTransactionVM for regression test

coveralls · 2017-06-01T11:19:04Z

Coverage decreased (-0.4%) to 77.55% when pulling 3819ba1 on sorpaas:master into 62c6667 on ethereumproject:master.

coveralls · 2017-06-01T11:19:04Z

Coverage decreased (-0.4%) to 77.55% when pulling 3819ba1 on sorpaas:master into 62c6667 on ethereumproject:master.

Solution: fix VM::used_gas

coveralls · 2017-06-01T11:56:24Z

Coverage decreased (-1.6%) to 76.322% when pulling 749dab7 on sorpaas:master into 62c6667 on ethereumproject:master.

sorpaas added 11 commits June 1, 2017 18:07

Problem: ETCDEVTeam#152 wrapping transactions for VM

4d8a962

Solution: add with_states fn for Machine

Problem: ETCDEVTeam#152 wrapping transactions for VM

948ed25

Solution: add TransactionVM

Problem: ETCDEVTeam#152 wrapping transactions for VM

c660780

Solution: add with_states for VM

Problem: ETCDEVTeam#152 wrapping transactions for VM

04defab

Solution: implement VM trait for TransactionVM

Problem: Transaction::gas_limit is unimplemented!()

b1a7416

Solution: add code for Transaction::gas_limit

Problem: Transaction::intrinsic_gas is unimplemented!()

483b6da

Solution: move necessary cost to transaction and impl intrinsic_gas

Problem: into_context is unimplemented!

b05a31e

Solution: implement into_context for message call and contract creation

Problem: Transaction is not exposed

a8618fd

Solution: pub use

Problem: CALL/CALLCODE should use the Transaction struct

bd9a427

Solution: utilize Transaction::into_context for those two opcodes

Problem: CREATE opcode does not use Transaction struct

3819ba1

Solution: utilize Transaction::into_context for CREATE

Problem: ETCDEVTeam#152 wrapping transactions for VM

1aa3ef1

Solution: use SeqTransactionVM for regression test

Problem: VM total used gas should include memory gas

749dab7

Solution: fix VM::used_gas

sorpaas mentioned this pull request Jun 1, 2017

Fix #117 #157

Merged

sjmackenzie merged commit 9ec2c84 into ETCDEVTeam:master Jun 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VM/Transaction trait/struct refactoring #155

VM/Transaction trait/struct refactoring #155

sorpaas commented Jun 1, 2017

coveralls commented Jun 1, 2017 •

edited

Loading

coveralls commented Jun 1, 2017

coveralls commented Jun 1, 2017 •

edited

Loading

VM/Transaction trait/struct refactoring #155

VM/Transaction trait/struct refactoring #155

Conversation

sorpaas commented Jun 1, 2017

coveralls commented Jun 1, 2017 • edited Loading

coveralls commented Jun 1, 2017

coveralls commented Jun 1, 2017 • edited Loading

coveralls commented Jun 1, 2017 •

edited

Loading

coveralls commented Jun 1, 2017 •

edited

Loading