Fix bugs until block number 51921 #193

sorpaas · 2017-06-08T16:42:54Z

See commits for details.

Solution: use another RPC get_uncle_by_block_number_and_index

Solution: unwrap

Solution: handle situation when commit account but contains key

Solution: reuse connections to improve performance

Solution: ExitedErr(_)

Solution: add parameter force_code_deposit in patch

Solution: calculate all_gas_cost first

Solution: add fresh_account_state variable

Solution: handle transfer when creating new machines

Solution: handle situaions where the key is already there

Solution: add create boolean to Context

Solution: fix refund gas cap

Solution: add create field for Context in jsontests

Solution: add ExecutionMode::None

coveralls · 2017-06-08T17:08:00Z

Coverage decreased (-0.4%) to 72.657% when pulling 9c3cf67 on sorpaas:master into e5bb586 on ethereumproject:master.

sorpaas added 15 commits June 8, 2017 05:02

Problem: uncle hash fetching is incorrect

e0ee06d

Solution: use another RPC get_uncle_by_block_number_and_index

Merge branch 'master' of github.com:sorpaas/sputnikvm

4d045e0

Problem: missing check return values in commit_account

7972f3e

Solution: unwrap

Problem: missing handling of complex account commitment fn

448950a

Solution: handle situation when commit account but contains key

Problem: RPC is slow

62483d5

Solution: reuse connections to improve performance

Problem: VM should eat all the gas when it fails

691eeff

Solution: ExitedErr(_)

Problem: before HOMESTEAD, code deposit are forced

cb85c91

Solution: add parameter force_code_deposit in patch

Problem: gas_limit and after_gas check potentially underflow

c25dda9

Solution: calculate all_gas_cost first

Problem: finalization should reset account state if error

84fe14d

Solution: add fresh_account_state variable

Problem: value should be transferred before EVM is run

06acf31

Solution: handle transfer when creating new machines

Problem: account commitment management for create is incomplete

f4f00ec

Solution: handle situaions where the key is already there

Problem: account should be created in prior to EVM execution

3447a65

Solution: add create boolean to Context

Problem: incorrect refund gas calculation

e7f67ae

Solution: fix refund gas cap

Problem: cargo test failed

c8cf118

Solution: add create field for Context in jsontests

Problem: jsontests requires None value transfer

9c3cf67

Solution: add ExecutionMode::None

sjmackenzie merged commit 1784f4b into ETCDEVTeam:master Jun 8, 2017

Provide feedback