Skip to content
This repository has been archived by the owner on Jan 12, 2020. It is now read-only.

special characters not supported? #7

Closed
jadster opened this issue Jun 3, 2017 · 4 comments
Closed

special characters not supported? #7

jadster opened this issue Jun 3, 2017 · 4 comments

Comments

@jadster
Copy link

jadster commented Jun 3, 2017

Looks like this tool doesn't allow for german Umlauts (öüä) in ENS names, eventhough they are supported by ENS. Is there a workaround?

@ricmoo
Copy link
Member

ricmoo commented Jun 3, 2017

You are correct. At this time I do not support characters outside of /^[0-9a-z-]*$/.

I can add a flag to the command line tool to override this though, if it is a feature people really want, but there are caveats that need to be understood.

It still remains to be seen how well support is going to be (at least in the near future) of names outside of this, and a lot of additional security concerns come up as well. Also, the library becomes much larger as it must contain a large database of all UTF-8 characters and how they relate to each other.

Depending on your browser, this may show up as apple.com: https://www.xn--80ak6aa92e.com/

Just as a quick example of the dangers of allowing the entire UTF-8 set; which gets converted into puny code, allowing homographs.

@jadster
Copy link
Author

jadster commented Jun 3, 2017

didn't realize the puny code urls allow homographs!

I just noticed that Mist/geth allow umlauts but not all UTF characters... no idea how that works... but I was hoping it would work better in ENS than in DNS world. Allowing for normal german spelling. also for personal German or french names (for personal wallets e.g.).

@x011
Copy link

x011 commented Jan 28, 2018

"I can add a flag to the command line tool to override this though"
Is this still an option?

@ricmoo
Copy link
Member

ricmoo commented Jan 12, 2020

This is hard to support in the CLI, but the tool run by ens makes this quite simple.

That said, keep in mind the danger of buying these domains; you will likely want to by all obvious pseudo-homoglyphs. For example, if you buy lächeln.eth, you will also want to prolly buy lacheln.eth.

Anyways, closing this now since it is managed in another repository now. Feel free to open a new ticket these. :)

@ricmoo ricmoo closed this as completed Jan 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants