resolver.getText but returns all of the text records

[makhnovskiy]

Interested to see if this exists or if there will be value adding a method to the resolver to return all the text record keys and their associated values. Currently resolver.getText('email') only returns a single key record, but would be great to have a method to return all keys and their values.

What are your thoughts?

[ricmoo]

This isn’t something that can be done by querying the contract, but you could easily write an event filter which would query all the text event changes and flatten them into the most recent value for each key.

[makhnovskiy]

@ricmoo Thanks for the response - would you be able to point or have any open docs for this? Or even psudo code that I could go off from?

Im assuming its this: https://docs.ethers.org/v6/api/utils/events/?

[makhnovskiy]

@ricmoo, Possible progress using getLogs but it returns all log data for that contract. Is is possible to filter this log data even more, for example, via the originating address?

    const publicResolverContractAddress = '0x231b0Ee14048e9dCcD1d247744d114a4EB5E8E63';

const eventTopic = [
      '0x448bc014f1536726cf8d54ff3d6481ed3cbc683c2591ca204274009afa09b1a1', 
      '0xc0e482f545380f3c76a14db8d5717d205abfdc508449ed2befe6d5427a9d45cd',
      '0x36c0d6cc28ff7763f02401a2d40c3a72c4dfdd8a6b812dfa978274306592721e'
    ];

let logs = await provider.getLogs({
      address: publicResolverContractAddress,
      fromBlock: '0x1024592',
      toBlock: '0x107D3F5',
      topics: [eventTopic]
    })

[ricmoo]

Yes, it should be. I’ve started writing some cookbook entries recently, I’ll include one for this for the next push. :)

[makhnovskiy]

@ricmoo That would be super awesome! Thanks for a great library!

[ricmoo]

Here is a quick example of how this can be done using event filters.

It is currently quite inefficient, but I will include the updated version in the cookbook, which will use the (soon to be released) MulticallProvider, which will reduce this to 2 eth_calls and an eth_getLogs. This version is 1+n eth_calls and an eth_getLogs for n text records. It should be out soon.

import { ethers } from "ethers";

const abi = [
  "event TextChanged(bytes32 indexed nodehash, string indexed _key, string key)"
];

async function getTextRecords(provider, name) {
  // Get the resolver for the name
  const resolver = await provider.getResolver(name);

  const contract = new ethers.Contract(resolver.address, abi, provider);

  // Get all the TextChanged logs for the name on its resolver
  const logs = await contract.queryFilter(contract.filters.TextChanged(ethers.namehash(name)));

  // Get the *unique* keys
  const keys = [ ...(new Set(logs.map((log) => log.args.key))) ];

  // Get the values for the keys
  const values = await Promise.all(keys.map((key) => {
      try {
          return resolver.getText(key);
      } catch (error) { }
      return null;
  }));

  // Return a nice dictionary of the key/value pairs
  return keys.reduce((accum, key, index) => {
      const value = values[index];
      if (value != null) { accum[key] = value; }
      return accum;
  }, { });
}

(async function() {
  const provider = new ethers.InfuraProvider();
  console.log(await getTextRecords(provider, "ricmoo.eth"));
})();

[makhnovskiy]

@ricmoo This is great, will be watching for the multicallProvider :) Thank you for your dedication to the library!

[makhnovskiy]

@ricmoo This implementation works great! But there are some profiles that have no log data using this filter (even though the scanner logs show data): https://etherscan.io/tx/0xf5bcb57aad6ab34e3a01dcf9fd3b7bdd3c69e9bb827a4e97e9ef8c0998602248#eventlog

for helloxyz.eth profile.

Other profiles are pulling up perfectly, such as nick.eth.

Any idea of why the log data doesnt return using queryFilter?

[ricmoo]

They may be using a non-standard Resolver. There isn’t any way around this unfortunately, with this method. It would be quite expensive (I’d think) to mine all the data for non-standard resolvers…

I have used non-standard resolvers myself before, and this is one of the biggest issues. :s

[makhnovskiy]

@ricmoo Going back at it again... Looks like a good amount of TextChanged events are not being returned. Im just looking at the (standard) ENS Public resolvers. Some work and some dont... These are some that dont:
helloxyz.eth: https://etherscan.io/tx/0xf5bcb57aad6ab34e3a01dcf9fd3b7bdd3c69e9bb827a4e97e9ef8c0998602248#eventlog
yayai.eth: https://etherscan.io/tx/0xa1fa79cb6356802e268d0e72af95c63dc5aabd85b9a0076e085d944a65e2b143#eventlog
pantaloons.eth: https://etherscan.io/tx/0xd2685923161b9921fc664660a42d4b0da3fbc547f7f8dca5f9a3a6bcfc092838#eventlog
gami.eth: https://etherscan.io/tx/0xa0060e0ebbb86a966e2b41f41171883bd4b045cfb6015342756bfceb16e04919#eventlog

It looks like a hit or miss... But of course a good portion do return the events no problems:
nick.eth
vitalik.eth

Initially I thought that the ENS: Public Resolver 2 (0x4976fb03C32e5B8cfe2b6cCB31c09Ba78EBaBa41) was the issue, but looks like some events are not returned from ENS: Public Resolver (0x231b0Ee14048e9dCcD1d247744d114a4EB5E8E63) as well.

What are your thoughts?