Handle getBlockNumber errors on polling #1235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricmoo
added
bug
ricmoo
added a commit
that referenced
this pull request
Jan 13, 2021
|
Superseded by the commit. Thanks |
ricmoo
added
fixed/complete
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
Fixes #1208
Fixes #1221
The error was caused by rejections at
this.perform("getBlockNumber", { })inBaseProvider._getInternalBlockNumbercausingthis._internalBlockNumberto be a rejected promise, then rejecting every laterawait internalBlockNumberand preventing it from being cleared. The fix is to handle rejections here together withgetNetworkchanges, clearing the rejected promise variable and passing the error through. This will give the chance for the nextpollto do a new request for the blockNumber.