JSON.parse RPC response only after receiving all chunks #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been fixed, please try it out and let me know if you still experience any problems. The test cases you provided are not in the test suite right now, but will likely be included in the future. :) Thanks! :) |
ricmoo
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The following error was thrown, when deploying contracts over an
IpcProvider:Solution
Buffer the RPC server's response chunks and parse them once they all arrive.
The arrival of the complete response is signalled by the RPC server requesting to end the connection.
A slight enhancement was added to the error reporting too, to show the response which couldn't be
JSON.parsed.