add option to not shuffle providers #588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One other thought - it might be nice to be able to specify a timeout for requests (maybe per-provider?), so that hanging requests trigger errors. Would you be interested in seeing something like this implemented? I'd be happy to do the work if you're likely to merge :) |
|
I think this should help add an equivalent of this feature in the newest version. Basically, only providers within the same "priority" are shuffled, so to ensure the order different priorities can be given to each. Please see the docs. Let me know what you think. Thanks! :) |
|
The priority feature looks great, and definitely addresses this issue! Thanks :) |
michaeltout
pushed a commit
to michaeltout/ethers.js
that referenced
this pull request
Aug 23, 2020
… are only approximate and supports per-provider priorities (ethers-io#635, ethers-io#588).
This was referenced Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking through the v5 implementation of the
FallbackProvider, I thought it might be nice to have an option not to shuffle providers. This option could be turned off by default (i.e. shuffle unless specifically told not to) as it is in this PR, but it would be a nice option in situations where developers want to call providers in a fixed order, only falling back to higher index providers in cases of errors.My other thought was to modify the
shuffledfunction to accept weights and do a weighted shuffle. In some ways this is more robust, but is also a bit harder to reason about (weighted shuffles seem strange). Let me know if you'd be more amenable to this approach, though.