Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: postage stamps support #115

Merged
merged 8 commits into from
Jun 2, 2021
Merged

feat: postage stamps support #115

merged 8 commits into from
Jun 2, 2021

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented May 26, 2021

Screen.Recording.2021-05-26.at.10.33.31.mov

@vojtechsimetka vojtechsimetka marked this pull request as ready for review June 1, 2021 08:16
@vojtechsimetka vojtechsimetka requested a review from a team June 1, 2021 20:35
@vojtechsimetka vojtechsimetka linked an issue Jun 2, 2021 that may be closed by this pull request
Copy link
Member

@agazso agazso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.

My only concern is that when buying a postage stamp fails (error 400, "out of funds") then there is no error indication whatsoever and the dialog just stays there. This could be probably addressed in a different PR though.

@vojtechsimetka vojtechsimetka merged commit 4074a9d into master Jun 2, 2021
@vojtechsimetka vojtechsimetka deleted the feat/postage-stamps branch June 2, 2021 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postage stamps page
3 participants