feat: update design of the accounting page #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vojtechsimetka
commented
Oct 4, 2021
•
vojtechsimetka
commented
vojtechsimetka
force-pushed
the
feat/accounting-page-redesign
branch
from
9e91c9b
to
883b650
Compare
vojtechsimetka
force-pushed
the
feat/accounting-page-redesign
branch
from
86b1bf1
to
1bcac76
Compare
vojtechsimetka
force-pushed
the
feat/accounting-page-redesign
branch
from
1363275
to
03497f4
Compare
vojtechsimetka
force-pushed
the
feat/accounting-page-redesign
branch
from
e145f0c
to
3be5097
Compare
vojtechsimetka
force-pushed
the
feat/accounting-page-redesign
branch
from
3be5097
to
c835f8c
Compare
Cafe137
reviewed
Oct 5, 2021
| } | ||
|
|
||
| return ( | ||
| <div className={`${classes.root} ${rootLevelClass}`}> | ||
| <ListItem button onClick={handleClick} className={classes.header}> | ||
| <ListItemText primary={<Typography variant={typographyVariant}>{label}</Typography>} /> | ||
| {open ? <ExpandLess /> : <ExpandMore />} | ||
| <div style={{ display: 'flex' }}> |
There was a problem hiding this comment.
<div style={{ display: 'flex' }}> is used 8 times in the project - I feel like this could be extracted as a super small helper component to avoid inline styles 🙂
There was a problem hiding this comment.
Created an issue out of it #213
Cafe137
reviewed
Oct 5, 2021
Cafe137
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.