Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional status checks (e.g. connected peers > 0 or funded chequebook) #331

Merged
merged 4 commits into from
Apr 13, 2022
Merged

feat: optional status checks (e.g. connected peers > 0 or funded chequebook) #331

merged 4 commits into from
Apr 13, 2022

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented Apr 11, 2022 •
edited
Loading

Fixes #329
Fixes #241

Screenshot 2022-04-11 at 18 20 49

Screenshot 2022-04-11 at 18 21 13

@bee-worker
Copy link
Collaborator

bee-worker commented Apr 11, 2022 •
edited
Loading

🐝 PR preview in Swarm

Preview URL: https://bah5acgzay7vzxctjwy5znmdtjb47nv2nu2l25jkwgmppuzcfwsxldsr2f3ea.bzz.link
Swarm Hash: c7eb9b8a69b63b96b0734879f6d74da697aea556331efa6445b4aeb1ca3a2ec8
Commit Hash: 8847111
Commit Message: fix: add checking for any error

@vojtechsimetka vojtechsimetka marked this pull request as ready for review April 11, 2022 16:20
@vojtechsimetka vojtechsimetka changed the title feat: make some check optional (e.g. connected peers > 0 or funded chequebook) feat: optional status checks (e.g. connected peers > 0 or funded chequebook) Apr 11, 2022
Cafe137
Cafe137 approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@Cafe137 Cafe137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V nice 🙂

@vojtechsimetka vojtechsimetka merged commit 5d0fbf7 into master Apr 13, 2022
@vojtechsimetka vojtechsimetka deleted the feat/introduce-warning-status branch April 13, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cafe137 Cafe137 Cafe137 approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
3 participants
@vojtechsimetka @bee-worker @Cafe137