Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for bzz.link cids when downloading files #350

Merged
merged 2 commits into from
Apr 25, 2022
Merged

feat: support for bzz.link cids when downloading files #350

merged 2 commits into from
Apr 25, 2022

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented Apr 24, 2022 •
edited
Loading

resolves #306

TODO:

  • write tests for the hash extraction
  • fix problem, where the regex matches any hash length that is between 64 and 128 characters

@bee-worker
Copy link
Collaborator

bee-worker commented Apr 24, 2022 •
edited
Loading

🐝 PR preview in Swarm

Preview URL: https://bah5acgzaozvltcmvmzxyw5s33btx3ne4lnxjkrpzwovzx5i2bytpabmmvr5a.bzz.link
Swarm Hash: 766ab98995666f8b765bd8677db49c5b6e9545f9b3ab9bf51a0e26f0058cac7a
Commit Hash: b7ce9df
Commit Message: test: add quite thorough testsuite

@vojtechsimetka vojtechsimetka marked this pull request as ready for review April 25, 2022 14:39
@thekingofcool
Copy link

nice

@vojtechsimetka vojtechsimetka merged commit 3784b29 into master Apr 25, 2022
@vojtechsimetka vojtechsimetka deleted the feat/detect-bzz-link-cids branch April 25, 2022 15:38
@bee-worker bee-worker mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cafe137 Cafe137 Cafe137 approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: add support for bzz.links when downloading
4 participants
@vojtechsimetka @bee-worker @thekingofcool @Cafe137