Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make blockchain JSON RPC configurable from settings #494

Merged
merged 3 commits into from
Jul 27, 2022
Merged

feat: make blockchain JSON RPC configurable from settings #494

merged 3 commits into from
Jul 27, 2022

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented Jul 26, 2022 •
edited
Loading

Resolves #480

TODO:

  • refactor to explode the config in the settings provider
  • update the RPC in the UI when changed
  • restart bee node

@bee-worker
Copy link
Collaborator

bee-worker commented Jul 26, 2022 •
edited
Loading

🐝 PR preview in Swarm

Preview URL: https://bah5acgzac27sebzmntbbue6ciki6ntgxrezuvhjlj2lb3qvwmpbrtlqphkaq.bzz.link
Swarm Hash: 16bf22072c6cc21a13c24291e6ccd789334a9d2b4e961dc2b663c319ae0f3a81
Commit Hash: 4c18e90
Commit Message: feat: restart bee node when blockchain RPC changes, add notification and error logging

@vojtechsimetka vojtechsimetka marked this pull request as ready for review July 26, 2022 16:46
@vojtechsimetka vojtechsimetka merged commit 408b565 into master Jul 27, 2022
@vojtechsimetka vojtechsimetka deleted the feat/make-blockchain-rpc-configurable branch July 27, 2022 06:45
@bee-worker bee-worker mentioned this pull request Jul 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cafe137 Cafe137 Cafe137 approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Let the RPC endpoint to be changed from the settings
3 participants
@vojtechsimetka @bee-worker @Cafe137