Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add starting state to sidebar indicator #587

Merged
merged 1 commit into from
Nov 22, 2022
Merged

feat: add starting state to sidebar indicator #587

merged 1 commit into from
Nov 22, 2022

Conversation

Cafe137
Copy link
Collaborator

@Cafe137 Cafe137 commented Nov 15, 2022

No description provided.

@bee-worker
Copy link
Collaborator

🐝 PR preview in Swarm

Preview URL: https://bah5acgza5stpajjczyolh4s2flkmmxz3wqntczohhooukeyhjhfn4zmtprcq.bzz.link
Swarm Hash: eca6f02522ce1cb3f25a2ad4c65f3bb41b3165c73b9d45130749cade65937c45
Commit Hash: ecb67f7
Commit Message: feat: add starting state to sidebar indicator

@Cafe137 Cafe137 marked this pull request as ready for review November 15, 2022 13:20
@Cafe137 Cafe137 linked an issue Nov 15, 2022 that may be closed by this pull request
Integrate the new loading state to status page and sidebar #585
Closed
AuHau
AuHau approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested it and works nicely, good job! 👍

@Cafe137 Cafe137 merged commit 848e61a into master Nov 22, 2022
@Cafe137 Cafe137 deleted the feat/add-starting-state-to-sidebar branch November 22, 2022 09:33
@bee-worker bee-worker mentioned this pull request Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AuHau AuHau AuHau approved these changes

@vojtechsimetka vojtechsimetka Awaiting requested review from vojtechsimetka

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate the new loading state to status page and sidebar
3 participants
@Cafe137 @bee-worker @AuHau