Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Topup and Dilute UI/UX #624

Closed
rampall opened this issue Sep 8, 2023 · 1 comment
Closed

improve Topup and Dilute UI/UX #624

rampall opened this issue Sep 8, 2023 · 1 comment
Labels
good first issue Good for newcomers type:issue

Comments

@rampall
Copy link
Contributor

rampall commented Sep 8, 2023

image

It is better from a UI/UX perspective to have two separate action buttons called "Topup" & "Dilute" instead of one action button "Topup & Dilute" considering that they are two very different actions from the user's perspective.
@bee-runner bee-runner bot added the type:issue label Sep 8, 2023
@Cafe137 Cafe137 added the good first issue Good for newcomers label Oct 31, 2023
@Cafe137
Copy link
Collaborator

Cafe137 commented Nov 1, 2023

StampExtensionModal is a combined component that handles both topup and dilute.

Topup is for increasing the amount (TTL) of a stamp that already exists.
Dilute is for increasing the depth (capacity) of a stamp that already exists.

It would be better to properly separate these.

@Cafe137 Cafe137 closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type:issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rampall @Cafe137