feat: data helpers for downloaded bytes #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agazso
reviewed
Mar 19, 2021
src/types/index.ts
Outdated
| @@ -64,6 +64,12 @@ export interface FileData<T> extends FileHeaders { | |||
| data: T | |||
| } | |||
|
|
|||
| export interface Data extends Uint8Array { | |||
| text: () => string | |||
| json: () => Record<string, any> | |||
There was a problem hiding this comment.
Currently using any gives a warning and it seems that there is some space for improvements here regarding the typing. I could even imagine having an optional validator function passed in to provide a return type information and to ensure that the returned type is valid. It doesn't have to be in this PR, just something to keep in mind.
agazso
reviewed
Mar 19, 2021
AuHau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191
Once approved, I will create follow up PR to
bee-js-docschanging the docs.