Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: chain and reserve state endpoints #324

Merged
merged 1 commit into from
May 26, 2021
Merged

feat: chain and reserve state endpoints #324

merged 1 commit into from
May 26, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented May 24, 2021

Closes #317

@AuHau AuHau requested a review from a team May 24, 2021 08:19
@AuHau AuHau requested a review from nugaon as a code owner May 24, 2021 08:19
nugaon
nugaon approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AuHau
Copy link
Contributor Author

AuHau commented May 25, 2021 •
edited
Loading

@nugaon what do you think? Currently, the block property in the chainState endpoint is also bigint even though it does not have to be as it should be small enough, but because I use the forceBigInt flag axios parse all numbers into bigints. Do you think it is a problem?

@nugaon
Copy link
Member

nugaon commented May 25, 2021

yeah, I noticed, I'm not bothered by that : ) though if this does'nt make you big difficulty you can keep it as number.

@AuHau AuHau merged commit 0ec57e9 into master May 26, 2021
@AuHau AuHau deleted the feat/reservestate-and-chainstate-endpoints branch May 26, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nugaon nugaon nugaon approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bee Debug: new endpoints ReserveState and ChainState
2 participants
@AuHau @nugaon