Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: topup and dilute batch methods #424

Merged
merged 10 commits into from
Oct 13, 2021
Merged

feat: topup and dilute batch methods #424

merged 10 commits into from
Oct 13, 2021

Conversation

AuHau
Copy link
Contributor

@AuHau AuHau commented Oct 6, 2021 •
edited
Loading

Part of #419

@AuHau AuHau requested a review from a team October 6, 2021 16:24
@AuHau AuHau requested a review from nugaon as a code owner October 6, 2021 16:24
@AuHau AuHau force-pushed the feat/postage-batch-endpoints branch from 68c1496 to d7e0bbd Compare October 12, 2021 13:15
Base automatically changed from bee-1.2.0 to master October 12, 2021 14:43
nugaon
nugaon reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@nugaon nugaon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the semaphore solution really acts semaphoric on Jest tests.

test/integration/bee-class.spec.ts Outdated Show resolved Hide resolved
test/integration/bee-class.spec.ts Outdated Show resolved Hide resolved
test/integration/bee-debug-class.spec.ts Outdated Show resolved Hide resolved
test/utils.ts Outdated Show resolved Hide resolved
@nugaon nugaon self-requested a review October 13, 2021 09:11
nugaon
nugaon approved these changes Oct 13, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
@AuHau AuHau force-pushed the feat/postage-batch-endpoints branch from 40b8a41 to 6563cf1 Compare October 13, 2021 09:19
@AuHau AuHau merged commit 7bf2135 into master Oct 13, 2021
@AuHau AuHau deleted the feat/postage-batch-endpoints branch October 13, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nugaon nugaon nugaon approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AuHau @nugaon