fix: add js suffix in imports for esm support with babel #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
force-pushed
the
fix/js-suffix-yab
branch
from
b9746e5
to
efd1932
Compare
vojtechsimetka
approved these changes
Feb 15, 2022
| import getMajorSemver from 'semver/functions/major' | ||
| import getMajorSemver from 'semver/functions/major.js' |
There was a problem hiding this comment.
Just for me to understand. These library imports have to have .js appended because they are also ESM? So if some other dependency (e.g. js-sha3) gets updated and bundeld as ESM, we would also add the suffix there?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially superseeds the #561 with using Babel to add the
.jssuffix and hopefully still functional tests.Closes #555