Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sharky leaks without a shard limit #2992

Closed
zelig opened this issue May 27, 2022 · 0 comments
Closed

sharky leaks without a shard limit #2992

zelig opened this issue May 27, 2022 · 0 comments
Assignees
Labels
bug Something isn't working enhancement enhancement of existing functionality

Comments

@zelig
Copy link
Member

zelig commented May 27, 2022

sharky without shard limit (as implemented in #2764) is unsound.
Without limit, every time a shard is full, it is extended (slots process pop call). Because of variance this will always happen eventually, therefore shards will grow with use infinitely probably causing disk to fill up #1258

@zelig zelig added bug Something isn't working enhancement enhancement of existing functionality labels May 27, 2022
This was referenced Aug 1, 2022
@istae istae self-assigned this Aug 9, 2022
@istae istae closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants