Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stamper index assignment rules changes #4539

Closed
istae opened this issue Jan 12, 2024 · 0 comments · Fixed by #4552
Closed

stamper index assignment rules changes #4539

istae opened this issue Jan 12, 2024 · 0 comments · Fixed by #4552
Assignees
Labels

Comments

@istae
Copy link
Member

istae commented Jan 12, 2024

The stamper.Stamp() should follow the rules below:

if the stamp item already exists, and the batch is mutable, reuse same index and use new timestamp.
if the stamp item already exists, and the batch is immutable, reuse the same stamp.
if the stamp does not exists, get a new index, and save the stamp item.

the other required change is that the Stamp function must be mutex protected per chunk (using multex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants