Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate localstore from swarm to bee #66

Closed
12 of 13 tasks
janos opened this issue Apr 7, 2020 · 1 comment
Closed
12 of 13 tasks

Migrate localstore from swarm to bee #66

janos opened this issue Apr 7, 2020 · 1 comment
Assignees
Labels
feature New functionality

Comments

@janos
Copy link
Member

janos commented Apr 7, 2020

Task

Localstore is the chunk storage implementation in the swarm project that needs to me migrated to the bee project. It depends on the shed package which currently uses leveldb to store data. It is agreed that badgerdb should be used instead, but in order to have clear trace of the changes and for easier code reviews, a multiple pull requests are beneficial. It is fine to have swarm and ethereum as dependencies between PRs, even if it does not look very nice, but it contributes to the clarity in the process.

  • 1. A PR that would include swarm shed package as it is.
  • 2. A PR that changes StructField to use encoding/json instead ethereum's rlp for encoding, to remove a dependency on ethereum codebase
  • 3. A PR that replaces shed ethereum's metrics with bee metrics, to remove a dependency on ethereum codebase
  • 4. A PR that replaces shed log library with bee logging library, to remove a dependency on swarm codebase
  • 5. A PR that replaces leveldb with badgerdb
  • 6. A PR that contains the localstore from swarm
  • 7. A PR that replaces localstore ethereum's metrics with bee metrics, to remove a dependency on ethereum codebase
  • 8. A PR that replaces localstore log library with bee logging library, to remove a dependency on swarm codebase
  • 9. A PR that removes explicit localstore migrations, but leaves the functionality to add new migrations
  • 10. A PR that migrates only needed swarm ethersphere/swarm/chunk package types to bee and replacing them in localstore
  • 11. A PR that replaces swarm shed with bee shed in localstore, and any references to leveldb that are left in localstore
  • 12. move localstore out of storage package
  • 13. fix SubscribePush tests that are set skipped in PR 11

Acceptance criterea

The goal would be to have localstore migrated to bee with the same exported api without any dependencies to swarm or ethereum projects.

@jmozah
Copy link
Contributor

jmozah commented Apr 9, 2020

@janos can you shed some light on PR 9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

No branches or pull requests

3 participants