You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.
In the last few weeks, we improved tracing with respect to retrieve requests. Currently the request part of the trace is mostly meaningful:
However the delivery part is missing. The spans defined in Peer.Deliver (swarm/network/stream/delivery.go) are broken. We should link them with the respective request part of the trace.
Delivery spans also start via the code in Peer.SendPriority, but there is no code that actually calls Finish for them.
Because of 1 and 2, we see when a chunk is retrieved locally on a given node (localstore.get span), but we have no idea when it is actually delivered to the requesting node.
After replacing SendPriority with Send, we can now trace a request from requestee node, back to requestor. It looks like we have a bug in the fetcher, because it is clear that a chunk is delivered, but the fetcher still requests it again from other peers:
In the last few weeks, we improved tracing with respect to retrieve requests. Currently the request part of the trace is mostly meaningful:
However the delivery part is missing. The spans defined in
Peer.Deliver
(swarm/network/stream/delivery.go
) are broken. We should link them with the respective request part of the trace.Delivery spans also start via the code in
Peer.SendPriority
, but there is no code that actually callsFinish
for them.Because of 1 and 2, we see when a chunk is retrieved locally on a given node (
localstore.get
span), but we have no idea when it is actually delivered to the requesting node.cc @nolash
The text was updated successfully, but these errors were encountered: