Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Fix tracing for chunk delivery #1292

Closed
2 tasks
nonsense opened this issue Mar 9, 2019 · 1 comment
Closed
2 tasks

Fix tracing for chunk delivery #1292

nonsense opened this issue Mar 9, 2019 · 1 comment
Assignees
Labels

Comments

@nonsense
Copy link
Contributor

nonsense commented Mar 9, 2019

In the last few weeks, we improved tracing with respect to retrieve requests. Currently the request part of the trace is mostly meaningful:

Screen Shot 2019-03-09 at 01 56 58

  1. However the delivery part is missing. The spans defined in Peer.Deliver (swarm/network/stream/delivery.go) are broken. We should link them with the respective request part of the trace.

  2. Delivery spans also start via the code in Peer.SendPriority, but there is no code that actually calls Finish for them.

Because of 1 and 2, we see when a chunk is retrieved locally on a given node (localstore.get span), but we have no idea when it is actually delivered to the requesting node.

cc @nolash

@nonsense
Copy link
Contributor Author

After replacing SendPriority with Send, we can now trace a request from requestee node, back to requestor. It looks like we have a bug in the fetcher, because it is clear that a chunk is delivered, but the fetcher still requests it again from other peers:

Screen Shot 2019-03-11 at 15 52 05

@FantasticoFox FantasticoFox moved this from Cold to Backlog in Swarm Core - Sprint planning May 23, 2019
@acud acud moved this from Backlog to To do in Swarm Core - Sprint planning May 28, 2019
@nonsense nonsense mentioned this issue Jun 17, 2019
13 tasks
@acud acud closed this as completed Oct 21, 2019
Swarm Core - Sprint planning automation moved this from To do to Done Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants