Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

test SWAP locks #1747

Closed
mortelli opened this issue Sep 11, 2019 · 2 comments
Closed

test SWAP locks #1747

mortelli opened this issue Sep 11, 2019 · 2 comments

Comments

@mortelli
Copy link
Contributor

It seems the locking scheme introduced in #1725 makes sense, and somewhat fixes the original problem in #1663.

However, we have not found a way to programmatically test this scheme yet.

@mortelli mortelli added this to Backlog go in Incentives Sprint planning Sep 11, 2019
@holisticode holisticode moved this from Backlog go to Done in Incentives Sprint planning Oct 1, 2019
@mortelli
Copy link
Contributor Author

mortelli commented Oct 3, 2019

apologies—i told @holisticode to close this one but upon further review i think we haven't covered it yet.

it's not a high priority issue: this is about implementing (if possible) tests to verify specifically how parallel routines/threads will behave when calling accounting functionalities and using shared resources.

@mortelli mortelli reopened this Oct 3, 2019
@mortelli mortelli moved this from Done to Backlog go in Incentives Sprint planning Oct 3, 2019
@mortelli
Copy link
Contributor Author

mortelli commented Jan 7, 2020

I'm closing this issue due to:

  • it being too ambitious, i.e. too hard to really test.
  • it being more related to testing golang itself, rather than the incentives module.

@mortelli mortelli closed this as completed Jan 7, 2020
@mortelli mortelli moved this from Backlog go to Done in Incentives Sprint planning Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

2 participants