@chadsr I'm not sure the PR to the main ethereum repo is necessary.
Everything in p2p/simulations is under our maintenance.

If anything, we should just PR into our master the pulling out of the vendor directory of the p2p/simulations directory, then PR to ethereum/go-ethereum a removal of the p2p/simulations directory (since they're not using it).

Please when you move stuff out of vendor use git mv and make sure you remove the appropriate entries in modules.txt.

Thanks!

@acud Makes sense. I'm happy to prepare said PRs and see if that's the general consensus. I'll then just rebase this PR to the migration.

Thanks for the feedback!

@acud After the input from fjl at go-ethereum, I figured this PR is still the best path to go?

Also in regards to the failing build, this is still reliant on a go-ethereum PR which was just merged into master.
It's not in the release yet, so this PR should not be merged until go-ethereum has released and the vendored version here has been updated.

Thanks for taking care of this PR @chadsr.
Approved pending vendoring of the necessary dependencies from go-ethereum on their next release.

There are build failures:

# github.com/ethersphere/swarm/network/simulation [github.com/ethersphere/swarm/network/simulation.test]
network/simulation/node.go:93: o.Properties undefined (type *adapters.NodeConfig has no field or method Properties)
network/simulation/node.go:132: conf.Properties undefined (type *adapters.NodeConfig has no field or method Properties)
network/simulation/simulation.go:123: ctx.Config.Properties undefined (type *adapters.NodeConfig has no field or method Properties)
network/simulation/node_test.go:237:27: sim.Net.GetNodeIDsByProperty undefined (type *simulations.Network has no field or method GetNodeIDsByProperty)
FAIL	github.com/ethersphere/swarm/network/simulation [build failed]

@janos This is due to what I mentioned above about depending on a new go-ethereum release.