Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional environment variables to configure Privacy Center and Google Tag Manager container for the "Cookie House" sample app #3347

Closed
NevilleS opened this issue May 22, 2023 · 2 comments · Fixed by #2949
Assignees

Comments

@NevilleS
Copy link
Contributor

NevilleS commented May 22, 2023

Is your feature request related to a specific problem?

For testing the fides.js Google Tag Manager (GTM) integration (aka window.Fides.gtm()), it'd be useful to have GTM set up in the sample application for manual & automated testing. This is similar to #3277 - the more "realistic" we can make the Cookie House, the better it will be as a testbed for us.

Similarly, we currently have the Privacy Center hardcoded to localhost, whereas that should be configurable for when we deploy this image.

Describe the solution you'd like

I'd like an optional environment variable, FIDES_SAMPLE_APP__GOOGLE_TAG_MANAGER_CONTAINER_ID that defaults to null. If set, we should include the tag manager <script> in the head of the sample app (see https://developers.google.com/tag-platform/tag-manager/web)

Additionally add FIDES_SAMPLE_APP__PRIVACY_CENTER_URL for the "Do Not Sell..." link and fetching fides.js

@NevilleS NevilleS self-assigned this May 22, 2023
@NevilleS
Copy link
Contributor Author

Hah, good news: this is literally already implemented here: #2949, just needs to be brought up-to-date with the clients refactor.

@NevilleS NevilleS changed the title Add an optional Google Tag Manager container to the "Cookie House" sample app Add optional environment variables to configure Privacy Center and Google Tag Manager container for the "Cookie House" sample app May 26, 2023
@Roger-Ethyca
Copy link

moving to done

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants