Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for new node environment setting #6

Closed
etianen opened this issue Nov 26, 2012 · 2 comments
Closed

Tests for new node environment setting #6

etianen opened this issue Nov 26, 2012 · 2 comments

Comments

@etianen
Copy link
Owner

etianen commented Nov 26, 2012

The tests.py module should ideally test both, but should skip the rhino/node tests when that environment is not available.

@jmbowman
Copy link

I thought about this when writing my patch, but haven't yet come up with a solution that seems satisfying. You can configure different tests to run in different environments, but verifying that the correct one was actually used is a little harder; the output should be the same in either case unless you also specify different optimizers. I guess just having tests that correctly produce output using what they think is the configured environment is a start.

@etianen
Copy link
Owner Author

etianen commented Nov 29, 2012

Now that #7 has made the default optimizer uglify, these tests should also use the closure compiler when testing the rhino environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants