Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a revision when an instance is deleted #796

Closed
alexkiro opened this issue Jun 26, 2019 · 3 comments
Closed

Add a revision when an instance is deleted #796

alexkiro opened this issue Jun 26, 2019 · 3 comments

Comments

@alexkiro
Copy link

It appears that a entry is not added in reversion_revision when an instance of the registered model is deleted. Either from admin or from a view.

It would be a nice addition to also store a revision in these cases for:

  • complete auditing
  • being able to more easily revert to a specific version in time in these cases (e.g. by recreating the deleted instance)
@etianen
Copy link
Owner

etianen commented Jun 26, 2019

It sounds like a good idea, but infortunately it's been tried before, and turned out to be a really bad idea in practice :P

If you're interested in the history behind this, check out #164

@etianen etianen closed this as completed Jun 26, 2019
@alexkiro
Copy link
Author

It sounds like a good idea, but infortunately it's been tried before, and turned out to be a really bad idea in practice :P

Oops, sorry for opening a dupe :)

If you're interested in the history behind this, check out #164

Will take a look, thanks!

@etianen
Copy link
Owner

etianen commented Jun 26, 2019

You're not the first, and you won't be the last. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants