Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Fallback Class Names #56

Merged
merged 3 commits into from Aug 22, 2016
Merged

Setup Fallback Class Names #56

merged 3 commits into from Aug 22, 2016

Conversation

fanfavorite
Copy link
Contributor

I am in a situation where I need to compile a list of videos after html5media has been run, so I figured that adding classes to the fallback versions would be the easiest solution.

I am in a situation where I need to compile a list of videos after html5media has been run, so I figured that adding classes to the fallback versions would be the easiest solution.
@etianen
Copy link
Owner

etianen commented Nov 28, 2014

Thanks for contributing!

I'm not sure about the utility of this addition, however. You can already add your own classes to the

@fanfavorite
Copy link
Contributor Author

What this does is allows you to select the fallback media that don't have a class as the regular videos you can select using the video tag. In my case, I can't add any classes to the content area as its dynamic content.

On Nov 28, 2014, at 5:01 AM, Dave Hall <notifications@github.commailto:notifications@github.com> wrote:

Thanks for contributing!

I'm not sure about the utility of this addition, however. You can already add your own classes to the and elements, and these will be copied to the fallback element. This also has the advantage that browsers which don't use the fallback will also be able to target the original elements with the same classes.

Reply to this email directly or view it on GitHubhttps://github.com//pull/56#issuecomment-64876052.

@etianen
Copy link
Owner

etianen commented Aug 22, 2016

Okay, so let's get this merged into a new release!

I'd suggest changing to class names to match the kebab-case convention that's generally used. How about html5media-video-fallback and html5media-audio-fallback?

@etianen etianen merged commit 2b6593e into etianen:master Aug 22, 2016
@etianen
Copy link
Owner

etianen commented Aug 22, 2016

1.2.1 is now out with these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants