Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rowwise operations #40

Merged
merged 39 commits into from
Feb 1, 2024
Merged

Implement rowwise operations #40

merged 39 commits into from
Feb 1, 2024

Conversation

etiennebacher
Copy link
Owner

@etiennebacher etiennebacher commented Aug 22, 2023 •
edited
Loading

Still WIP, close #24

TODO:

  • add checks for groups + rowwise won't handle groups now, just throw an error. Not enough experience with this, I just use rowwise() alone

@etiennebacher
start work on rowwise
1901f96
@etiennebacher
start tests
96a83ea
@etiennebacher
update test
484d44a
@etiennebacher
Merge branch 'main' into rowwise
627e4d8
@etiennebacher
refactor, add some testss
2f4a393
@etiennebacher
ungroup, print, dplyr method
9d26a14
@etiennebacher
fix some tests
f84aceb
@etiennebacher
minor refactor
f552847
@etiennebacher
fix test
cddb10e
@etiennebacher
Merge branch 'main' into rowwise
7e7d11a
@etiennebacher
Merge branch 'main' into rowwise
f13fe9e
@etiennebacher
merge main
74ab988 
Merge branch 'main' into rowwise

# Conflicts:
#	R/funs-default.R
#	R/funs-string.R
#	R/group_by.R
#	R/print.R
#	R/utils-tidyselect.R
#	R/zzz.R
#	tests/tinytest/test_ungroup_lazy.R
@etiennebacher
merge
8b87a90
@etiennebacher
missing docs
74c979f
@etiennebacher
Merge branch 'main' into rowwise
e061597
@etiennebacher
pl_rowwise -> rowwise
166a467
@etiennebacher
same
31c1626
@etiennebacher
PoC [skip ci]
9523e39
@etiennebacher
Merge branch 'main' into rowwise [skip ci]
19c6941
@etiennebacher
more [skip ci]
3c8927b
@etiennebacher
still wip
2030d52
@etiennebacher
fix all and any
e89e227
@etiennebacher
add test for ungroup after rowwise
b0b03a3
@etiennebacher
find a workaround for case_match and case_when
042c4de
@etiennebacher
fix for str_replace_all
85097dc
@etiennebacher
fix test for ungroup
3a03cd8
@etiennebacher
fix behavior of all and any when only NA
9831392
@etiennebacher
add some todo
263f048
@etiennebacher
fix all and any
7b227db
@etiennebacher
some docs
5c76172
@etiennebacher etiennebacher marked this pull request as ready for review February 1, 2024 08:07
@etiennebacher etiennebacher merged commit 2a0b61a into main Feb 1, 2024
7 checks passed
@etiennebacher etiennebacher deleted the rowwise branch February 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rowwise operations
1 participant
@etiennebacher