Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calibration conversion 2d and 3d takes integers as source points #52

Closed
lpasselin opened this issue Sep 1, 2020 · 2 comments
Closed

Calibration conversion 2d and 3d takes integers as source points #52

lpasselin opened this issue Sep 1, 2020 · 2 comments
Assignees
@etiennedub
Labels
question Further information is requested

Comments

@lpasselin
Copy link
Collaborator

Should source_points be floats instead of integers? Both the inputs and outputs of the related SDK functions are floats?

https://github.com/etiennedub/pyk4a/blob/develop/pyk4a/calibration.py#L33

https://microsoft.github.io/Azure-Kinect-Sensor-SDK/master/group___functions_gaacd1eab997ef964b5e436afa5295726e.html#gaacd1eab997ef964b5e436afa5295726e
@lpasselin lpasselin added the question Further information is requested label Sep 1, 2020
@etiennedub
Copy link
Owner

Yes you are right. We should change for float in the c code. Also, I noted that the thread_safe arg is missing in the python function. I open issue #55 for that.

@lpasselin
Copy link
Collaborator Author

will be fixed in #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etiennedub etiennedub

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lpasselin @etiennedub