Skip to content

Commit

Permalink
Letting ContactDetails handle the "tap outside to close"
Browse files Browse the repository at this point in the history
  • Loading branch information
etiennesegonzac committed Mar 4, 2012
1 parent 0ca400a commit a74a188
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions apps/dialer/js/contacts.js
Expand Up @@ -229,6 +229,14 @@ var ContactDetails = {
_editing: false, _editing: false,
setup: function cd_setup() { setup: function cd_setup() {
window.addEventListener('keyup', this, true); window.addEventListener('keyup', this, true);

// click outside details container to close
this.overlay.addEventListener('click', function(evt) {
ContactDetails.hide();
});
this.container.addEventListener('click', function(evt) {
evt.stopPropagation();
});
}, },
get overlay() { get overlay() {
delete this.overlay; delete this.overlay;
Expand Down Expand Up @@ -473,14 +481,6 @@ window.addEventListener('load', function contactSetup(evt) {
ShortcutsHandler.setup(); ShortcutsHandler.setup();
ContactDetails.setup(); ContactDetails.setup();


// click outside details container to close
document.getElementById('contacts-overlay').addEventListener('click', function(evt) {
ContactDetails.hide();
});
document.getElementById('contact-details-container').addEventListener('click', function(evt) {
evt.stopPropagation();
});

// add scrollwheel fallback for browser users // add scrollwheel fallback for browser users
var scrollNode = Contacts.view; var scrollNode = Contacts.view;
scrollNode.addEventListener('DOMMouseScroll', wheel, false); scrollNode.addEventListener('DOMMouseScroll', wheel, false);
Expand Down

0 comments on commit a74a188

Please sign in to comment.