Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I think the emphasis is not displayed correctly (in Windows). #4

Closed
GoodWillChase opened this issue Mar 17, 2019 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@GoodWillChase
Copy link

I think it should be:

strong, b {
    font-weight: 800;
}
@GoodWillChase GoodWillChase changed the title I think the emphasis is not displayed correctly (in windows). I think the emphasis is not displayed correctly (in Windows). Mar 17, 2019
@etigerstudio
Copy link
Owner

Hello, Thank you for try Misty Theme out!

I've made some tests before and finally selected 400 as body font weight, 500 as strong/b font weight on Windows(300, 400 on macOS respectively).
For me, it turns out that 500 & 600 render as same thickness(see first shot) and 700 & 800 render as same thickness(see second shot):

500
800

As you can see in these 2 shots, whose font rendered is 'Segoe UI', 500 & 600 are a little thin and visually subtle, while 700 & 800 are rather thick and visually obstructive, damaging entire feel.

For this reason, I choose 500(may also be adjusted to 600 if needed) instead of 800 as strong/b font weight on Windows.

@etigerstudio
Copy link
Owner

I'm planning to change font weight to (300,500) on macOS & (400,600) on Windows from (300,400) on macOS & (400,500) on Windows to make it a little more obvious to distinguish between normal & bold text.

@GoodWillChase
Copy link
Author

GoodWillChase commented Mar 18, 2019

I've done some tests and maybe I know where the problem is.

I changed strong/b font weight (line 505 in the 'misty-light-windows.css').

For me, it turns out that 400 & 500 render as same thickness(see first shot) and 600 & 700 render as same thickness(see second shot) and 800 & 900 render as same thickness which is much more thicker(see third shot):

FSCapture_2019-03-18_10-52-13

FSCapture_2019-03-18_11-05-11

FSCapture_2019-03-18_11-08-06

So I think you just need to choose 600 instead of 500 as strong/b font weight on Windows and it will be all okay.

Maybe it's a Windows System problem or something else. I don't know. Hope it helps.

@etigerstudio
Copy link
Owner

Thank you for opening this issue & doing experiments!

Fixed in v0.4.1.
If you find any other problem or have any other idea on the theme, free feel to open up another issue!

@etigerstudio etigerstudio added the bug Something isn't working label Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants