This repository has been archived by the owner on Sep 23, 2023. It is now read-only.
Temporarily fix build (Mirai-Purpur 1.18.2) #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also changed the version name in another commit to fix compatibility with EssentialsX because it does not recognise the version name containing "(Purpur build)" |
|
What does EssX do to break with this? |
I sadly combined two things in one PR |
Can you create two different PRs? I'm closing this one to not mess with the fixes |
|
yes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build issue on github actions on the purpur 1.18.2 branch by changing the version of Simple-YAML used by Mirai.
This is probably only needed until Purpur updates their Pufferfish upstream.