Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default encoding of OctetString #194

Closed
the-useless-one opened this issue Apr 29, 2020 · 7 comments
Closed

Default encoding of OctetString #194

the-useless-one opened this issue Apr 29, 2020 · 7 comments

Comments

@the-useless-one
Copy link

Hi!

The default defined encoding of a univ.OctetString seems to be ISO-8859-1 (see the code here). I was wondering why this choice was made, instead of something more universal, like UTF8?

This default encoding is causing some weird behavior in some programs relying on this library (see here or here).

Is it possible to change the default encoding to UTF8? If not, why not, and what do you suggest we can do to ensure proper encoding in our programs?

Thanks!

Y

@the-useless-one
Copy link
Author

Up, any info regarding this issue? Thanks!

@the-useless-one
Copy link
Author

Up, anything I can do to help resolve this issue? Right now, I'm not able to port my project to Python 3. Thanks!

@GIJack
Copy link

GIJack commented Jun 30, 2020

Hi, this is actually important because pyasn1 is buried in the dep chain for CrackMapExec, which in turn needs pywerview.

There are a whole bunch of people that depend on this to work as expected.

It should be noted, UTF-8 is the now favored internationalization standard. Please switch to this.

@the-useless-one
Copy link
Author

Up, has anyone any news on this project? There seems to have been no commit since march, and @etingof does not seem to be active anymore on Github, or other websites, such as StackOverflow, and such. I hope everything's okay.

Kind regards,

Y

@GIJack
Copy link

GIJack commented Oct 28, 2020

Prime example of the "joys" of working with Free software sometimes.

@the-useless-one
Copy link
Author

@GIJack, I can understand the frustration of not getting any response, but please keep in mind that open source developers have other concerns outside of their projects, especially during this dumpster fire of a year.

@the-useless-one
Copy link
Author

After re-reading LDAP RFCs (thanks @ThePirateWhoSmellsOfSunflowers), we reached the conclusion that the problem may not come from pyasn1. We managed to fix our problem another way, so I'm closing this issue.

We wish @etingof a speedy recovery, and good health!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants