Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading torchvision model types lazily #692

Closed
da-liii opened this issue Jul 5, 2022 · 0 comments · Fixed by #693
Closed

Loading torchvision model types lazily #692

da-liii opened this issue Jul 5, 2022 · 0 comments · Fixed by #693

Comments

@da-liii
Copy link
Collaborator

da-liii commented Jul 5, 2022

With #691, we will solve the problem that torchvision version is fixed.

However, for now, the torchvision dependencies are required even when we are using Rikai with Tensorflow.

import rikai.pytorch.models.convnext
import rikai.pytorch.models.efficientnet
import rikai.pytorch.models.fasterrcnn
import rikai.pytorch.models.feature_extractor
import rikai.pytorch.models.keypointrcnn
import rikai.pytorch.models.maskrcnn
import rikai.pytorch.models.resnet
import rikai.pytorch.models.retinanet
import rikai.pytorch.models.ssd
import rikai.pytorch.models.ssd_class_scores

I suggest that we should not load the above model types when torchvision is not installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant