Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter issues #13

Closed
3 tasks done
etolbakov opened this issue Jun 12, 2023 · 2 comments
Closed
3 tasks done

Fix linter issues #13

etolbakov opened this issue Jun 12, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@etolbakov
Copy link
Owner

etolbakov commented Jun 12, 2023 •
edited

The code is in relatively untidy state. Commands

cargo check --all-features
cargo fmt -- --check
cargo clippy -- -D warnings

produce a lot of actions (unused code, not optimal methods etc). This needs to be addressed.

  • clippy issues
  • cargo check
  • format issues
@etolbakov etolbakov added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 12, 2023
@etolbakov
Copy link
Owner Author

Partially addressed in #23

@etolbakov etolbakov mentioned this issue Jun 19, 2023
Merged
@etolbakov
Copy link
Owner Author

Fully addressed here
#32
Declared #[allow(clippy::too_many_arguments)] for some functions as it's by-design. Potentially, could be addressed later at some point.

@etolbakov etolbakov mentioned this issue Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@etolbakov