Remove extra Object.keys check in the timer_data loop

statsd · Feb 28, 2013 · ec4056e · ec4056e
1 parent 757359a
commit ec4056e
Showing 1 changed file with 13 additions and 16 deletions.
diff --git a/backends/graphite.js b/backends/graphite.js
@@ -76,7 +76,7 @@ var post_stats = function graphite_post_stats(statString) {
       graphiteStats.last_exception = Math.round(new Date().getTime() / 1000);
     }
   }
-}
+};
 
 var flush_stats = function graphite_flush(ts, metrics) {
   var ts_suffix = ' ' + ts + "\n";
@@ -110,26 +110,23 @@ var flush_stats = function graphite_flush(ts, metrics) {
   }
 
   for (key in timer_data) {
-    if (Object.keys(timer_data).length > 0) {
+    var namespace = timerNamespace.concat(key);
+    var the_key = namespace.join(".");
+    for (timer_data_key in timer_data[key]) {
       var namespace = timerNamespace.concat(key);
       var the_key = namespace.join(".");
-      for (timer_data_key in timer_data[key]) {
-        var namespace = timerNamespace.concat(key);
-        var the_key = namespace.join(".");
-
-        if (typeof(timer_data[key][timer_data_key]) === 'number') {
-          statString += the_key + '.' + timer_data_key + ' ' + timer_data[key][timer_data_key] + ts_suffix;
-        } else {
-          for (timer_data_sub_key in timer_data[key][timer_data_key]) {
-            l.log(timer_data[key][timer_data_key][timer_data_sub_key].toString());
-            statString += the_key + '.' + timer_data_key + '.' + timer_data_sub_key + ' ' +
-                          timer_data[key][timer_data_key][timer_data_sub_key] + ts_suffix;
-          }
+
+      if (typeof(timer_data[key][timer_data_key]) === 'number') {
+        statString += the_key + '.' + timer_data_key + ' ' + timer_data[key][timer_data_key] + ts_suffix;
+      } else {
+        for (timer_data_sub_key in timer_data[key][timer_data_key]) {
+          l.log(timer_data[key][timer_data_key][timer_data_sub_key].toString());
+          statString += the_key + '.' + timer_data_key + '.' + timer_data_sub_key + ' ' +
+                        timer_data[key][timer_data_key][timer_data_sub_key] + ts_suffix;
         }
       }
-
-      numStats += 1;
     }
+    numStats += 1;
   }
 
   for (key in gauges) {