Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tcp based repeater #445

Closed
wants to merge 2 commits into from
Closed

Conversation

kelaneren
Copy link

#204

It's very useful for some cases.

@mrtazz
Copy link
Member

mrtazz commented Aug 28, 2014

Thanks for taking the time to submit this! As the functionality is very simple to the existing repeater, it would probably make sense to fold them into one and have a configuration option to use either UDP or TCP. Thoughts?

@kelaneren
Copy link
Author

yes, it could. I kept it separately for a few reasons:

  1. tcp connection is much more expensive than sending udp packet. So in the tcp repeater I used connection pool which is a unnecessary node module for udp one if you don't care about tcp.
  2. keeping them separate, you could have both at the same time. after merging, you only can use either of them.

I am going to send you another pull request for the merged version. You decide which one you keep. Also, one connection pool bug is fixed in the new pull

@kelaneren kelaneren closed this Aug 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants