New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support histograms #162
Merged
Merged
support histograms #162
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4c2ee9d
support histograms
6f51d04
clarify bins can be arbitrarily wide
50dd2ae
support different histogram settings for different metrics
92c46c3
bugfix: allow bin upper limits to contain decimals
6582ea2
clarify histogram/bin categorisation algorithm
Dieterbe 9308691
merge branch 'master'
Dieterbe 3fe3d43
add tests for histograms
Dieterbe 7a9d9f3
put all histogram bins in a "histogram" sub-hierarchy
Dieterbe 338fbd5
remove metric name sanitisation. this is a task for the backends
7447b55
bugfix: make sure histogram metric path is correct
Dieterbe ac2a390
Merge pull request #248 from draco2003/master
mrtazz 3feedf2
Merge branch 'histogram' of github.com:Dieterbe/statsd into histogram…
f0a9361
make histograms work with the graphite backend
d246dab
move percentThreshold in global namespace for now
2ca3d21
implement graphite test for histograms
08eb71a
remove timer subsection that was never used
2d256e2
clarify histogram graphite test: use a bin that actually includes the…
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,8 @@ function flushMetrics() { | |
sets: sets, | ||
counter_rates: counter_rates, | ||
timer_data: timer_data, | ||
pctThreshold: pctThreshold | ||
pctThreshold: pctThreshold, | ||
histogram: config.histogram | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this doesn't work. It has to be |
||
} | ||
|
||
// After all listeners, reset the stats | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we generally want to push key name sanitization into the backends, since a
.
separator could be completely valid in one backend but not the_
. So I think we should remove this here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense. would you be willing to add that commit, it's probably quicker than having a conversation on how exactly you want the sanitization be done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just remove the
replace()
part. The rest is ok I think.