Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated stats.js to delete counters #183

Merged
merged 8 commits into from Nov 29, 2012
Merged

Updated stats.js to delete counters #183

merged 8 commits into from Nov 29, 2012

Commits on Oct 25, 2012

  1. Updated stats.js to delete counters 

    Counters are now deleted after being used, not set to zero.  This solves
some issues with high load on Graphite and certain graphing functions
which require null instead of 0 counters.
    Patrick McCoy committed Oct 25, 2012
    Copy the full SHA
    01da23d View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2012

  1. Update stats.js 

    Changed from delete to undefined, per some info on delete from Mozilla https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Operators/delete

This keeps the array element there, just sets it's value to undefined.
    Patrick McCoy committed Oct 30, 2012
    Copy the full SHA
    e3f7924 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2012

  1. Update test/graphite_tests.js 

    Updating the test to work with new null count change.
    Patrick McCoy committed Oct 31, 2012
    Copy the full SHA
    71df1bd View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2012

  1. Update stats.js 

    Added a config option delete_counters with a default: false to control the behavior of the counters metrics to delete.
    Patrick McCoy committed Nov 1, 2012
    Copy the full SHA
    777ea8c View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2012

  1. Tests for Delete Counters Config 

    Added tests for the delete counters config change.
    Patrick McCoy committed Nov 13, 2012
    Copy the full SHA
    1e66b4e View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2012

  1. Updated the example config docs with the new option

    Patrick McCoy committed Nov 14, 2012
    Copy the full SHA
    24390ee View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2012

  1. Changed stats.js to use delete 

    Changed stats.js to use delete instead of setting the values to
undefined in order to save some memory.
    Patrick McCoy committed Nov 26, 2012
    Copy the full SHA
    c03f339 View commit details
    Browse the repository at this point in the history

  2. Fixed the tests 

    Fixed the tests that were broken when changing to delete
    Patrick McCoy committed Nov 26, 2012
    Copy the full SHA
    d0901b8 View commit details
    Browse the repository at this point in the history