lib/helpers: fixed is_valid_packet() #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces following changes: * Be liberal in what you recieve - do not rely on regexps for packet parsing but instead accept anything that can be parsed by JavaScript as a number e.g: +1e-17, -0511, 0xDEADbeef, etc * Accept both positive and negative counters with explicit / implicit sign * Provides more strict error checking then regexp, for example following strings match previously used '([\-\+\d\.]+' regexp: . .123. .\-+\0\+-.1- Also while here added more tests. Closes: statsd#350 statsd#357 Signed-off-by: Alexey Ivanov <SaveTheRbtz@GMail.com>
|
Looks good, thanks for submitting this! |
mrtazz
added a commit
that referenced
this pull request
Feb 11, 2014
lib/helpers: fixed is_valid_packet()
| case 'g': | ||
| return isNumber(fields[0]); | ||
| case 'ms': | ||
| return isNumber(fields[0]) && Number(fields[0]) > 0; |
There was a problem hiding this comment.
Should this be Number(fields[0]) >= 0?
There was a problem hiding this comment.
Indeed it should, if you have time you can patch it and add test for that particular case. If not, I'll probably do it myself within a week or so.
SaveTheRbtz
pushed a commit
to SaveTheRbtz/statsd
that referenced
this pull request
Feb 23, 2014
Pointed out by: jeffyip in statsd#382 [1] [1] statsd#382 (comment)
SaveTheRbtz
pushed a commit
to SaveTheRbtz/statsd
that referenced
this pull request
Feb 23, 2014
Pointed out by: jeffyip in statsd#382 [1] [1] statsd#382 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces following changes:
parsing but instead accept anything that can be parsed by JavaScript
as a number e.g: +1e-17, -0511, 0xDEADbeef, etc
sign
following strings match previously used '([-+\d.]+' regexp:
.
.123.
.-+\0+-.1-
Also while here added more tests.
Closes: #350 #357 #363
Signed-off-by: Alexey Ivanov SaveTheRbtz@GMail.com