New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker support #573
Add Docker support #573
Conversation
That config is worked for me. +1 for a approve the pull request. |
Bump. |
Seems trivial to also include a |
Added docker-compose manifest. Uses dockerana/* Docker Hub's official images for graphite-web and carbon and builds the statsd image from current dir. |
lgtm! What's the benefit of having these files in the root of the project? Does DockerHub search for these files this way? (Total docker n00b questions im sure) |
Checked it, and the Node image tag we are using here ( Also, IIRC Docker can't add files outside the Dockerfile parent dir for security reasons. I've used the |
@pataquets I would probably pin to node 5.x While the tests are passing against node-stable, which travis says is 6.0.0, they are also outputting some deprecation errors to stderr which should get a closer look at before using the latest Node image |
Sounds safer. I've modified the Dockerfile to pin the Node version to the latest 5.x available. |
Bump. |
Thanks for the patch! Just FYI I've released the latest on npm as 0.8.0 so you could base your docker build on that if you'd like |
How about creating an 'official' automated build at Docker Hub for the image? |
Bump. |
How about the above proposed 'official' Docker Hub image? Looks like 'etsy' user/org is already registered (hopefully by you): https://hub.docker.com/u/etsy/ |
Bump. |
@pathzzrd : ping |
Any feedback on creating an 'official' automated build from source on Docker Hub? |
@pathzzrd : any update on this? |
Add Dockerfile to enable image building.
By now, I use the official Node image, 'onbuild' tag. More info at https://hub.docker.com/_/node/
Later, I just simply copy the exampleConfig.js into config.js and replace the 'graphite.example.com' hostname by 'graphite' to enable Docker native networking, be it via linking or via aliasing external hosts/containers as 'graphite' and always connect to the 'graphite' host.
Build:
Run (assuming a previously running Graphite Docker conatiner named graphite):
More optional improvements to come: