Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not allowed characters in UVCI for DK entries #42

Closed
martin-lindstrom opened this issue May 10, 2021 · 8 comments
Closed

Not allowed characters in UVCI for DK entries #42

martin-lindstrom opened this issue May 10, 2021 · 8 comments

Comments

@martin-lindstrom
Copy link
Collaborator

@jvitrifork Creating an issue since we don't have a better way of communicating.

The format of the UVCI (ci) used in DK files contains characters outside of the allowed character set. See https://github.com/ehn-digital-green-development/ehn-dgc-schema/wiki/FAQ.

@jvitrifork
Copy link
Contributor

An issue is fine.

Yep - that's a bug

@jvitrifork
Copy link
Contributor

How fast do you expect the corrected test files from me?

@martin-lindstrom
Copy link
Collaborator Author

martin-lindstrom commented May 10, 2021

@jvitrifork Are you asking me? I am just a user of this repo just as you. Just wanted you to know about the problem.

@jvitrifork
Copy link
Contributor

ok - well, thanks for the heads up

@JChrist
Copy link

JChrist commented May 10, 2021

Also, there seems to be a schema validation for r and t fields, at least in test 1.json
According to the schema, r and t MUST have minItems: 1, as specified here:
https://github.com/ehn-digital-green-development/ehn-dgc-schema/blob/main/DGC.schema.json#L51
However, in the test file, r and t exist with no items (empty array).

@jvitrifork
Copy link
Contributor

Fix comming up

@jvitrifork
Copy link
Contributor

@martin-lindstrom @JChrist @nodh issues should be fixed with #49

@daniel-eder
Copy link
Member

Fixed in #49 - thank you @jvitrifork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants