Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Broken rule should yield "open", not "false" #116

Closed
chrloch opened this issue Oct 4, 2021 · 6 comments
Closed

[iOS] Broken rule should yield "open", not "false" #116

chrloch opened this issue Oct 4, 2021 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@chrloch
Copy link

chrloch commented Oct 4, 2021

Description

When a rule is broken (e.g. features an undefined variable), the verifier app on iOS yields a failed status for this rule.

Expected behaviour

The status of the rule should be OPEN (as it is in the Android version)

Steps to reproduce the issue

This can be reproduced scanning a valid vaccination DCC and verifying for Switzerland.
VR-CH-0004 and VR-CH-0006 contain a reference to "var":"external.validationClockAtStartOfDay" which does not exist.

Technical details

Reproduced with ACC backend

@chrloch chrloch added the bug Something isn't working label Oct 4, 2021
@chrloch chrloch changed the title Broken rule should yield "open", not "false" [iOS] Broken rule should yield "open", not "false" Oct 4, 2021
@kerstin-oppermann-tsi
Copy link

@chrloch any idea how to test this issueon an other way? The reference to "var":"external.validationClockAtStartOfDay" doesn't exist in the Switzerland Rules (on ACC)

@chrloch
Copy link
Author

chrloch commented Nov 2, 2021

I can create a broken rule for the DX country again.

@kerstin-oppermann-tsi
Copy link

This would be good when @ihorkhomyak or @ivlasov implemented a fix for that issue.

@kerstin-oppermann-tsi
Copy link

@chrloch can you retest this issue or provide a broken rule for testing

@chrloch
Copy link
Author

chrloch commented Nov 9, 2021

I don't have an iOS device but I have created a broken rule to become effective in two days:
[rule service acc] /rules/DX/2b77f485a984ae9fb52a14b8ba4bf52948f9948c6a6bf3b3d0c15f052b7b6263

@kerstin-oppermann-tsi
Copy link

image
Seems issue is fixed now with verifier 1.2.3.1(12)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants