Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - TAN input should be after displaying the values of the certificate #88

Closed
kerstin-oppermann-tsi opened this issue Jul 15, 2021 · 10 comments
Assignees

Comments

@kerstin-oppermann-tsi
Copy link

kerstin-oppermann-tsi commented Jul 15, 2021

## Describe the bug

When I scan a QR Code at next step should be displayed the details informations of the certificate.
Steps should be like in iOS wallet app. the behaviour on iOS is according to spec, on Android it is not.

In iOS steps are like this:

  1. scan QR Code
  2. display cert details and SAVE button
  3. tap on SAVE
  4. input TAN
@alexchornyi
Copy link

@kerstin-oppermann-tsi not a bug. We can't validate TAN and after that send this TAN to claim certificate. TAN may used only ones. BE side not ready for this functionality.

@kerstin-oppermann-tsi
Copy link
Author

kerstin-oppermann-tsi commented Jul 20, 2021

@alexchornyi But on Android it works like in the screenshots shown.

  1. At first tthe QR Code is scanned.
  2. Then without displaying any infos of the cert the TAN has to put in.
  3. And when the TAN is correct then all infos of the cert are displayed.

This is the behaviour we discussed in the test team to have similiar in both apps.

@PaulBallmann
Copy link

@kerstin-oppermann-tsi - Afaik the behaviour on iOS is according to spec, on Android it is not. So maybe we should align Android to the iOS implementation then?

@kerstin-oppermann-tsi
Copy link
Author

@PaulBallmann yes we discussed this with Hendrik yesterday, I will put this ticket to Android for fixing.

@kerstin-oppermann-tsi kerstin-oppermann-tsi transferred this issue from eu-digital-green-certificates/dgca-wallet-app-ios Jul 21, 2021
@kerstin-oppermann-tsi kerstin-oppermann-tsi changed the title iOS - TAN input should to be the first after scanning the QR Code before displaying the values of the certificate Android - TAN input should to be after displaying the values of the certificate Jul 21, 2021
@kerstin-oppermann-tsi
Copy link
Author

@oleksandrsarapulovgl I moved this issue from iOS to Android because the iOS behaviour is like spec, so Android should be changed according to this.

@kerstin-oppermann-tsi kerstin-oppermann-tsi changed the title Android - TAN input should to be after displaying the values of the certificate Android - TAN input should be after displaying the values of the certificate Jul 21, 2021
@oleksandrsarapulovgl
Copy link
Contributor

PR: #90

@RalicaY
Copy link
Collaborator

RalicaY commented Jul 27, 2021

@oleksandrsarapulovgl , @Hendrik-Schmidt-Schierhorn-TSI Retest on Android Wallet 1.1.2 was NOT successful -- the old state is to be observed (that is, TAN input is needed before Data can be displayed).

@oleksandrsarapulovgl
Copy link
Contributor

@RalicaY looks like that it wasn't merge in current pre-release, sorry. Let's check then in next one please, I'll discuss to prepare one today.

@oleksandrsarapulovgl
Copy link
Contributor

@RalicaY could you please recheck on latest build?

@RalicaY
Copy link
Collaborator

RalicaY commented Jul 28, 2021

Successfully retested in 1.1.4-tst.

@RalicaY RalicaY closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants