Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with nim 0.17.0 #1

Closed
yuliyv opened this issue Jun 16, 2017 · 4 comments
Closed

Compatibility issue with nim 0.17.0 #1

yuliyv opened this issue Jun 16, 2017 · 4 comments

Comments

@yuliyv
Copy link

yuliyv commented Jun 16, 2017

When attempting to utilize this package with the latest nim version (0.17.0) I was getting the following error while running the test suite:

$ nim c -r tests/main.nim 
/Users/yuliy/code/dotenv.nim/dotenv.nim(40, 38) template/generic instantiation from here
lib/system.nim(2656, 7) Error: can raise an unlisted exception: ref AssertionError

Which I believe stems from the addition of a doAssert in the core os module (found here).

I believe that this change in my fork should resolve the issue and maintain backwards compatibility with previous versions, but I am fairly new to nim so any feedback is appreciated!

@euantorano
Copy link
Owner

euantorano commented Jun 16, 2017

Thanks for the report, I can't seem to replicate the issue with either Nim 0.17.0 or $HEAD on my machine, which is odd...

@euantorano
Copy link
Owner

I cannot replicate this locally, but have pushed an updated version with some changes to directory structure and with documentation included. I've also asked on IRC to see if it's some quirk in my setup that prevents that exception from being thrown.

@euantorano
Copy link
Owner

Araq pointed me in the right direction - that exception won't be raised on Windows which explains why I'm not seeing it on this machine!

@yuliyv
Copy link
Author

yuliyv commented Jun 16, 2017

Thanks for your help on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants