Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use prettified URL for blog posts. #229

Merged
merged 2 commits into from Jun 26, 2016
Merged

Use prettified URL for blog posts. #229

merged 2 commits into from Jun 26, 2016

Conversation

blattms
Copy link
Contributor

@blattms blattms commented Jan 19, 2016

When setting prettify_urls to True, Page.path is not the URL that the page is
uploaded to but the one where the source of the page is (including a possible
.html extension). Therefore this commit uses Page.final_url which does
not have the bogus .html extension when using prettified URLs.

@blattms
Use prettified URL for blog posts.
af83989 
When setting prettify_urls to True, Page.path is not the URL that the page is
uploaded to but the one where the source of the page is (including a possible
.html extension). Therefore this commit uses Page.final_url which does
not have the bogus .html extension when using prettified URLs.
@blattms
Copy link
Contributor Author

blattms commented Jan 19, 2016

I guess the problem I had is similar to the one described in #157. Therefore I guess merging this PR closes #157

@blattms blattms mentioned this pull request Jan 19, 2016
Closed
@blattms
Copy link
Contributor Author

blattms commented Feb 13, 2016

This PR closes #233

@blattms
Copy link
Contributor Author

blattms commented Feb 13, 2016

Closes #234

@matthewjewell matthewjewell mentioned this pull request Apr 4, 2016
Closed
@antons
Copy link
Contributor

antons commented Apr 23, 2016

page.path on line 84 must be also replaced with page.final_url.

@blattms
Also use final_url in prebuildPage.
ba0beff 
Kudos to @antons for pointing that out.
@blattms
Copy link
Contributor Author

blattms commented May 12, 2016

@antons Nice catch. Fixed it.

Just hoping that somebody, e.g. @krallin, will somewhen merge this to master.

@ibarria0 ibarria0 merged commit c5664e1 into eudicots:master Jun 26, 2016
@blattms blattms mentioned this pull request Jun 26, 2016
Merged
@blattms
Copy link
Contributor Author

blattms commented Jun 26, 2016

Thanks for merging. Great to see some momentum!

@blattms blattms deleted the prettify-urls-in-post-context branch June 26, 2016 16:43
@blattms blattms mentioned this pull request Sep 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blattms @antons @ibarria0