Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 1 - Awesome Books Plain Javascript with Objects #2

Merged
merged 19 commits into from Jul 5, 2022

Conversation

chelmerrox
Copy link
Collaborator

@chelmerrox chelmerrox commented Jul 5, 2022

Hi! This PR is for milestone 1. We've completed the requirements to:

  • Implement only a basic UI with plain HTML
  • Create a collection that keeps a list of books
  • Create a function to add a new book to the collection, with title and author.
  • Create a function to remove a book from the collection
  • Display all books saved in the collection in the top part of the page.
  • When a user clicks the "Add" button:
    a) A new book is added to the collection.
    b) The new book is displayed on the page.
  • When a user clicks the "Remove" button:
    a) The correct book is removed from the collection.
    b) The correct book disappears from the page.
  • Make sure that data is preserved in the browser's memory by using [localStorage]

Thanks in advance for your review, comments & help!

Copy link

@omar-labana omar-labana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔️

Hi

Congratulations on completing this project! 👏🏼 🎉

You have correctly implemented all of the requirements📃 correctly and without any errors⚠️ or bugs🪲.

Cheers and good luck in your next milestones! 🍀

Feel free to leave any questions or comments in the PR thread(don't forget to tag me 😄) if something is not 100% clear.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@chelmerrox chelmerrox merged commit 720a97e into master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants