requests should be event emitters

[focusaurus]

I need to mock doing req.on('end', onEnd); and the mock request class does not have the event emitter methods.

[estilles]

@focusaurus, the mockRequest implementation in this project aims to mock Express' request class and Node's http.IncomingMessage (which Express' request extends), neither of which are event emitters.

It's possible you believe mockRequest mocked Node's http.request, which is not the case.

If you have any additional questions or comments feel free to reopen this issue.

[focusaurus]

neither of which are event emitters.

Node's http.IncomingMessage subclasses Stream.readable as seen here.

Stream.readable inherits from stream, which is an event emitter as seen here

In the repl, you can see that http.IncomingMessage clearly has an "on" function.

new http.IncomingMessage().on
[Function]

Streaming in node is built upon the event emitter pattern, and HTTP messages support streaming.

[estilles]

@focusaurus, you're absolutely right. My apologies. Let me see if I can work on implementing this.

[estilles]

We're scheduling this feature for our v2.0 release.

[jvwing]

I worked around this issue by mashing an instance of node-memorystream with node-mock-http's mockRequest. The mockRequest is then a stream, complete with event support sufficient to fool body-parser. The end() method is used to flush the stream.

Underscore hackery aside, this seems like a reasonable approach to supporting request-as-stream. Would a pull request for adding stream support based on node-memorystream be welcomed?

var assert = require("assert");
var bodyParser = require("body-parser");
var httpMocks = require("node-mocks-http");
var MemoryStream = require("memorystream");
var _ = require("underscore");

describe("Testing form post with body-parser", function () {
    var urlEncodedParser = bodyParser.urlencoded({ "extended": false, "limit": "32kb" });
    var memStream = new MemoryStream();
    var httpMocksRequest = httpMocks.createRequest({
        "method": "POST",
        "headers": {
            "content-type": "application/x-www-form-urlencoded",
            "transfer-encoding": "chunked"
        }
    });
    var mockRequest = _.extend(memStream, httpMocksRequest);
    var mockResponse = httpMocks.createResponse();
    var nextCalled = false;
    before(function () {
        urlEncodedParser(mockRequest, mockResponse, function () {
            nextCalled = true;
        });
        mockRequest.end("name=Some+Dude&email=some.dude%40foobar.com");
    });
    it("Called Next", function () {
        assert.equal(nextCalled, true);
    });
    it("Parsed Body", function () {
        assert.equal(mockRequest.body.name, "Some Dude");
        assert.equal(mockRequest.body.email, "some.dude@foobar.com");
    });
});

[evanshortiss]

Hey,

I came across this also and just added the following in mockRequest.js:

var events = require('events');
var mockRequest = Object.create(events.EventEmitter.prototype);

This allows me to fire events on the mockRequest in test cases. Happy to submit a PR.

[evanshortiss]

Here's a sample commit link with the change.

[github-actions]

Stale issue message