Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CNAME to git ignore #33

Closed
antonioortegajr opened this issue Mar 7, 2020 · 4 comments
Closed

Add CNAME to git ignore #33

antonioortegajr opened this issue Mar 7, 2020 · 4 comments

Comments

@antonioortegajr
Copy link
Member

The CNAME file should not be changed by contributors so this should be included in gitignore

@Hyraze
Copy link
Contributor

Hyraze commented Apr 22, 2020

Add CNAME in .gitignore

@antonioortegajr
Copy link
Member Author

@Hyraze Thanks! That is is exactly what is needed.

Also: So the issue is here for new contributors. This repo and a few other repos around town leave straight forward issues for anyone wanting to do a pull request for the first time. SO it's less about any code fix ups and more about learning the git flow and we have a real issue to guide them with on the first go.

@Hyraze
Copy link
Contributor

Hyraze commented Apr 26, 2020

@antonioortegajr Sorry to say, there isn't any way for now to stop "CNAME" from being forked since it is a remote repository..The only thing that you can ace is to have a well documentation about the way to deal with "CNAME".

@antonioortegajr
Copy link
Member Author

@Hyraze OK, will label this a invalid/close and create doc issue for this CNAME. Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants